Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fset: fix fset.color.help_description not applying #1988

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

nathanielevan
Copy link
Contributor

Description

[why]
The fset.color.help_description setting previously didn't apply to its corresponding UI element, in this case the description of configuration variable in the help bar in fset.

[how]
Change code that configures the foreground colour of this UI element to apply the aforementioned setting.

@nathanielevan
Copy link
Contributor Author

Quick demonstration of how this looks like:

old new
scshot-310723-212620 scshot-310723-232820

@flashcode flashcode self-assigned this Aug 8, 2023
@flashcode flashcode added the bug Unexpected problem or unintended behavior label Aug 8, 2023
@flashcode flashcode added this to the 4.1.0 milestone Aug 8, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1988 (a6cb6bd) into master (06fa592) will decrease coverage by 0.01%.
Report is 11 commits behind head on master.
The diff coverage is 20.00%.

❗ Current head a6cb6bd differs from pull request most recent head 9b838c5. Consider uploading reports for the commit 9b838c5 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1988      +/-   ##
==========================================
- Coverage   47.25%   47.25%   -0.01%     
==========================================
  Files         215      215              
  Lines       90466    90468       +2     
==========================================
  Hits        42754    42754              
- Misses      47712    47714       +2     
Files Changed Coverage Δ
src/plugins/fset/fset-bar-item.c 9.72% <0.00%> (-0.28%) ⬇️
src/plugins/irc/irc-channel.c 60.85% <0.00%> (ø)
src/gui/gui-input.c 56.98% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@flashcode flashcode merged commit 070f0da into weechat:master Aug 8, 2023
10 checks passed
@flashcode
Copy link
Member

flashcode commented Aug 8, 2023

Thanks!

flashcode added a commit that referenced this pull request Aug 8, 2023
flashcode added a commit that referenced this pull request Aug 8, 2023
@nathanielevan nathanielevan deleted the fix-fset-description branch August 13, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants