Passive DCC #2004

mario-campos · 2023-08-23T00:36:41Z

This PR adds initial support for passive DCC. Specifically, it supports a non-WeeChat client sending DCC SEND with a port of 0, which causes weechat to open a listening socket, accept the first client that connects, and start a new xfer.

It does (or should) respect the xfer.network.own_ip config property.
It does (or should) respect the xfer.network.port_range config property.
It does (or should) support the passive DCC RESUME extension (linked above).

Closes #487.

This makes it easier to handle the optional "token" argument at the (right) end, which will be necessary to support passive DCC. Incidentally, this is RtL parsing order is the reason why you'd get a cryptic "0" address error when attempting to do passive DCC: the "token" argument gets misinterpreted as the "size" argument. Every argument "shifts" over by one, leaving an address (port) of "0".

Before making any significant changes, let's identify the existing xfer types by either active or passive.

flashcode

The token is never set by WeeChat itself so if I understand WeeChat only supports passive DCC as a "receiver".

The help on command /dcc (ie /help dcc) should maybe mention passive DCC being supported.

Besides, the unit tests are failing, because some network address resolution seems to be made and causes a test to fail.

src/plugins/irc/irc-command.c

src/plugins/irc/irc-ctcp.c

src/plugins/xfer/xfer.c

mario-campos · 2023-08-23T13:31:15Z

The token is never set by WeeChat itself so if I understand WeeChat only supports passive DCC as a "receiver".

Correct.

The help on command /dcc (ie /help dcc) should maybe mention passive DCC being supported.
Besides, the unit tests are failing, because some network address resolution seems to be made and causes a test to fail.

I'll address these.

flashcode · 2023-08-23T13:32:59Z

How can I test this passive DCC, which client and/or IRC server are you using?

mario-campos · 2023-08-23T14:01:26Z

You'll need a public IP address and to expose a port—I tested with IPv4.

Then, join #THE.SOURCE and #The.Lounge on irc.scenep2p.net. Look for a XDCC bot with P in the nick to ensure it will trigger the passive-DCC code. See here for SceneP2P's instructions.

As for the clients, I've tested with irssi and Weechat.

mario-campos · 2023-08-23T23:38:31Z

@flashcode, can you please point me to the file that contains the help docs (/help dcc)?

flashcode · 2023-08-24T07:29:40Z

@flashcode, can you please point me to the file that contains the help docs (/help dcc)?

/dcc is an IRC command so it's located in irc-command.c: https://github.com/weechat/weechat/blob/master/src/plugins/irc/irc-command.c#L7097

codecov-commenter · 2023-08-27T05:03:26Z

Codecov Report

Merging #2004 (06306b9) into master (49f52cc) will increase coverage by 0.11%.
Report is 36 commits behind head on master.
The diff coverage is 46.93%.

❗ Current head 06306b9 differs from pull request most recent head 46d0601. Consider uploading reports for the commit 46d0601 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #2004      +/-   ##
==========================================
+ Coverage   47.10%   47.22%   +0.11%     
==========================================
  Files         216      216              
  Lines       91314    91774     +460     
==========================================
+ Hits        43017    43342     +325     
- Misses      48297    48432     +135

Files Changed	Coverage Δ
src/core/hook/wee-hook-fd.c	`33.07% <0.00%> (ø)`
src/core/hook/wee-hook-focus.c	`18.34% <0.00%> (ø)`
src/core/hook/wee-hook-process.c	`0.00% <0.00%> (ø)`
src/core/hook/wee-hook-timer.c	`31.11% <0.00%> (ø)`
src/core/wee-debug.c	`23.35% <0.00%> (+0.08%)`	⬆️
src/plugins/fset/fset-buffer.c	`3.16% <0.00%> (-0.02%)`	⬇️
src/plugins/fset/fset-config.c	`85.88% <0.00%> (ø)`
src/plugins/irc/irc-command.c	`20.16% <0.00%> (-0.09%)`	⬇️
src/plugins/irc/irc-config.c	`61.02% <0.00%> (-0.08%)`	⬇️
src/plugins/irc/irc-list.c	`14.02% <0.00%> (-0.03%)`	⬇️
... and 37 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This commit also includes support for passive DCC RESUME. There was also a potential segfault with calling `atoi(pos_token)` when `pos_token` is NULL, so `token` is set to be stored as a string. Although it is an integer, we don't need to store it as such. That's really more of an implementation detail.

mario-campos · 2023-08-28T02:17:19Z

@flashcode, can you try running the test suite again? It should pass now.

mario-campos · 2023-08-31T17:41:35Z

@flashcode, have you been able to test this PR?

flashcode · 2023-08-31T17:56:12Z

I'll test it soon, in the next days.

flashcode · 2023-09-06T17:17:09Z

Merged, thanks for adding this new feature!

flashcode · 2023-09-15T06:16:12Z

Hi @mario-campos,

For your information, this PR introduced a regression with DCC chat, causing a crash when you do /dcc chat <nick>.

I fixed the issue in this commit e62ff28 and you could look if my changes are OK for you.
At least I tested the DCC chat which is now working again, but didn't fully retest the passive DCC.

mario-campos · 2023-09-15T13:51:29Z

Sorry about introducing that regression. I retested the passive DCC functionality against the HEAD of master (f49810e) and it still works. Thanks!

ksurl · 2023-11-16T20:44:59Z

how should the port range be written in xfer.conf?

will a dash work? or does it use a colon

port_range = "2000-2010"

flashcode · 2023-11-17T08:30:29Z

@ksurl: it's a dash, see /help xfer.network.port_range:

description: restricts outgoing files/chats and incoming/passive files to use only ports
in the given range (useful for NAT) (syntax: a single port, ie. 5000 or a port range,
ie. 5000-5015, empty value means any port, it's recommended to use ports greater than 1024,
because only root can use ports below 1024)

mario-campos added 2 commits August 22, 2023 19:29

xfer: add and identify active/passive xfer types.

5a8abd4

Before making any significant changes, let's identify the existing xfer types by either active or passive.

flashcode added the feature New feature request label Aug 23, 2023

flashcode requested changes Aug 23, 2023

View reviewed changes

src/plugins/irc/irc-command.c Show resolved Hide resolved

src/plugins/irc/irc-ctcp.c Show resolved Hide resolved

src/plugins/irc/irc-ctcp.c Show resolved Hide resolved

src/plugins/xfer/xfer.c Outdated Show resolved Hide resolved

flashcode self-assigned this Aug 23, 2023

mario-campos added 2 commits August 27, 2023 12:30

xfer: update command/config docs with passive DCC support.

46d0601

mario-campos force-pushed the mario-campos/passive-dcc branch from 44dbace to 46d0601 Compare August 27, 2023 17:32

flashcode approved these changes Aug 31, 2023

View reviewed changes

flashcode added the in progress Someone is working on this issue label Sep 6, 2023

flashcode added a commit that referenced this pull request Sep 6, 2023

irc: fix code style (issue #2004)

1f1416d

flashcode added a commit that referenced this pull request Sep 6, 2023

xfer: fix code style (issue #2004)

6eb3f56

flashcode added a commit that referenced this pull request Sep 6, 2023

core: update ChangeLog (issue #2004)

5f5f058

flashcode added a commit that referenced this pull request Sep 6, 2023

core: add contributor (issue #2004)

65e092a

flashcode added a commit that referenced this pull request Sep 6, 2023

core: update translations (issue #2004)

1be5209

flashcode removed the in progress Someone is working on this issue label Sep 6, 2023

flashcode closed this Sep 6, 2023

flashcode added this to the 4.1.0 milestone Sep 6, 2023

flashcode mentioned this pull request Sep 6, 2023

Passive DCC #487

Closed

mario-campos deleted the mario-campos/passive-dcc branch September 7, 2023 16:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Passive DCC #2004

Passive DCC #2004

mario-campos commented Aug 23, 2023 •

edited

flashcode left a comment

mario-campos commented Aug 23, 2023

flashcode commented Aug 23, 2023

mario-campos commented Aug 23, 2023

mario-campos commented Aug 23, 2023

flashcode commented Aug 24, 2023

codecov-commenter commented Aug 27, 2023 •

edited

mario-campos commented Aug 28, 2023

mario-campos commented Aug 31, 2023

flashcode commented Aug 31, 2023

flashcode commented Sep 6, 2023

flashcode commented Sep 15, 2023

mario-campos commented Sep 15, 2023

ksurl commented Nov 16, 2023

flashcode commented Nov 17, 2023

Passive DCC #2004

Passive DCC #2004

Conversation

mario-campos commented Aug 23, 2023 • edited

flashcode left a comment

Choose a reason for hiding this comment

mario-campos commented Aug 23, 2023

flashcode commented Aug 23, 2023

mario-campos commented Aug 23, 2023

mario-campos commented Aug 23, 2023

flashcode commented Aug 24, 2023

codecov-commenter commented Aug 27, 2023 • edited

Codecov Report

mario-campos commented Aug 28, 2023

mario-campos commented Aug 31, 2023

flashcode commented Aug 31, 2023

flashcode commented Sep 6, 2023

flashcode commented Sep 15, 2023

mario-campos commented Sep 15, 2023

ksurl commented Nov 16, 2023

flashcode commented Nov 17, 2023

mario-campos commented Aug 23, 2023 •

edited

codecov-commenter commented Aug 27, 2023 •

edited