core: add wildcard matching operators to eval (closes #608) #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,6 +42,8 @@ enum t_eval_comparison | |||
| { | |||
| EVAL_COMPARE_REGEX_MATCHING = 0, | |||
| EVAL_COMPARE_REGEX_NOT_MATCHING, | |||
| EVAL_COMPARE_MATCHING, | |||
There was a problem hiding this comment.
For less ambiguity, I would use name EVAL_COMPARE_STRING_MATCHING and EVAL_COMPARE_STRING_NOT_MATCHING.
There was a problem hiding this comment.
I thought about naming it better too, I'll modify that then.
|
If possible, could you please add the tests of the new operators in tests/unit/core/test-eval.cpp ? |
|
I can also add some tests, sure. Forgot because I don't usually add features to the core. |
arza-zara
approved these changes
Oct 2, 2016
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds two operators,
=*and!*, for matching/not matching strings by wildcard mask instead of more complicated regex. The=*operator was chosen instead of the suggested=%because the latter has lesser connection with wildcards, in my opinion.Also this patch does not implement the "match against a list" behavior asked for because it does not make sense for one operator to be able to match against a list, while all the others match against a single string.