Fix for unclosed/leaking sockets from issue #358 #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hope @flashcode is willing to merge this before 1.6's release, it's been affecting a lot of people. Thanks for figuring out what was causing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was server->sock not being set unless the connection was successful. In the case of SSL connections, a connection could be established but not be successful because it wasn't an SSL port or the SSL certificate did not validate. In those cases irc_server_close_connection() was called, but it was checking for server->sock != -1 before calling gnutls_bye() or close(). Since close() was never called for the socket, it would get stuck in the CLOSE_WAIT state until weechat was closed.
This will also fix issue #573 when the unclosed sockets exceed the fd limit.