-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package to address deprecation warnings #625
Comments
That is a good issue I will work on the first warning and make a PR
|
As a result of fixing the first deprecation warning I think it solved the second warning as they are related |
I will work on the last task
|
fixing the deprecation warning in the first two tasks of the issue #625
I have worked on the fifth issue:
I have issued a pull request, please review it. Thanks! |
I have worked on issue 4. please view my pull request Expected None, but tests/test_FasterRCNN.py::test_retinanet returned <deepforest.models.FasterRCNN.Model object at 0x7f91cba5d940>, which will be an error in a future version of pytest. Did you mean to use assert instead of return? |
We have a growing number of deprecation warnings accumulating. Below are a number of these warnings that are produced by the current test suite. These aren't all necessarily from DeepForest directly (they may be upstream), but we should start finding the ones that are in DeepForest and update to get ahead of these changes. For folks looking for starter issues a great thing to do is to pick a single warning below, find one of our tests that produces the deprecation warning, and then see if the warning is triggered directly by the code run by that test or if it is upstream. If it is in the DeepForest code then work on a PR to fix just that warning and run the whole test suite to make sure that your fixes catches all instances of it in the code base.
None
for 'weights' are deprecated since 0.13 and may be removed in the future. The current behavior is equivalent to passingweights=FasterRCNN_ResNet50_FPN_Weights.COCO_V1
. You can also useweights=FasterRCNN_ResNet50_FPN_Weights.DEFAULT
to get the most up-to-date weights.assert
instead ofreturn
?op
parameter is deprecated and will be removed in a future release. Please use thepredicate
parameter instead."Directly specifying the num_classes arg in deepforest.main will be deprecated in 2.0 in favor of config_args. Use main.deepforest(config_args={'num_classes':value})" main.py line 66If you are working on one of these please drop a note in this issue with which warning you are working on so that folks don't duplicate effort.
EDIT: Removed the last item since we're generating it intentionally
The text was updated successfully, but these errors were encountered: