Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions build passing when tests erroring #651

Closed
ethanwhite opened this issue Apr 2, 2024 · 0 comments · Fixed by #652
Closed

GH Actions build passing when tests erroring #651

ethanwhite opened this issue Apr 2, 2024 · 0 comments · Fixed by #652
Assignees
@ethanwhite

Comments

@ethanwhite
Copy link
Member

In the process of debugging the failed tests I noticed that in some cases the build passes even when a bunch of tests error:

image

From: https://github.com/ethanwhite/DeepForest/actions/runs/8516671872/job/23326049120
@ethanwhite ethanwhite self-assigned this Apr 2, 2024
ethanwhite added a commit to ethanwhite/DeepForest that referenced this issue Apr 2, 2024
@ethanwhite
Run tests, style, and notebook checks as separate jobs
3ab1649 
Running them together was causing the build to pass even when tests were failing.

Fixes weecology#651.
This was referenced Apr 2, 2024
Closed
Merged
@bw4sz bw4sz closed this as completed in #652 Apr 9, 2024
@bw4sz bw4sz closed this as completed in 6b1c199 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanwhite ethanwhite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GH Actions tests ethanwhite/DeepForest
1 participant
@ethanwhite