Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing cran failing issues #160

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Addressing cran failing issues #160

wants to merge 23 commits into from

Conversation

juniperlsimonis
Copy link
Member

@juniperlsimonis juniperlsimonis commented Sep 11, 2023

build issue associated with downloading resources for vignette building

Quitting from lines 201-225 [download pre-generated model outputs] (paper-comparison.Rmd)
Error: processing vignette 'paper-comparison.Rmd' failed with diagnostics:
cannot open URL 'https://raw.githubusercontent.com/weecology/LDATS-replications/master/output/ldats_ldats.RDS'
--- failed re-building ‘paper-comparison.Rmd’

converting to precomputing approach following https://ropensci.org/blog/2019/12/08/precompute-vignettes/

also, because this is the first update in a bit, using github actions for replacing travis

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch has no changes to coverable lines.

❗ Current head fb638d8 differs from pull request most recent head 4aefa8a. Consider uploading reports for the commit 4aefa8a to get more accurate results

Files Changed Coverage
R/LDA.R ø
R/LDA_TS.R ø
R/TS.R ø
R/ptMCMC.R ø

📢 Thoughts on this report? Let us know!.

@juniperlsimonis juniperlsimonis changed the title adding github workflows Addressing cran failing issues Sep 16, 2023
move vignette out of folder and rbuildignore it
wiley online library does some anti-text scraping thing now that apparently throws a 403 when httr tries to GET it, using alternative links for a few papers
@diazrenata this is my attempt to get the precompiling approach to work following https://ropensci.org/blog/2019/12/08/precompute-vignettes/.

the vignette needs to be pre built by collowing the precompile.R script in the paper_comparison folder, which is ignored for the R build
so all the figures are in one folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants