Merge pull request #501 from Deborah-Digges/remove-from-loop

Remove string join operation from loop to improve performance
weecology · Jun 6, 2016 · 1592c96 · 1592c96
2 parents e3600c1 + e291211
commit 1592c96
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/templates.py b/lib/templates.py
@@ -64,12 +64,13 @@ def exists(self, engine=None):
 
     def matches_terms(self, terms):
         try:
-            for term in terms:
-                search_string = ' '.join([
+            search_string = ' '.join([
                     self.name,
                     self.description,
                     self.shortname
-                ] + self.tags).upper()
+                ] + self.tags).upper()      
+
+            for term in terms:
                 if not term.upper() in search_string:
                     return False
             return True