Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #1637

Closed
henrykironde opened this issue Jan 21, 2022 · 6 comments · Fixed by #1645
Closed

Improve test coverage #1637

henrykironde opened this issue Jan 21, 2022 · 6 comments · Fixed by #1645
Assignees

Comments

@henrykironde
Copy link
Contributor

Currently Codecov code coverage is at 60%. Let us aim for 75%+

@Nageshbansal
Copy link
Contributor

@henrykironde, I have to increase the number of tests so that test coverage can improve?

@henrykironde
Copy link
Contributor Author

Some lines of code are not tested, so we need to identify them and try to create tests to cover those lines.

@Nageshbansal
Copy link
Contributor

@henrykironde , i have made 65% code coverage , should I make PR now ?

@henrykironde
Copy link
Contributor Author

Yes make a PR so that I can review the changes.

@Nageshbansal
Copy link
Contributor

Nageshbansal commented Feb 11, 2022

@henrykironde can you please assign this issue to me, I'm working on this and I already increased coverage up to 65% by adding tests for create_socrata_dataset.

@Nageshbansal
Copy link
Contributor

Nageshbansal commented Feb 14, 2022

@henrykironde The SEDAC data source contains raster, vector datasets we can try to add these datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants