Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for more code coverage #1645

Merged
merged 5 commits into from
Apr 26, 2022

Conversation

Nageshbansal
Copy link
Contributor

@Nageshbansal Nageshbansal commented Feb 12, 2022

Fixes #1637

Copy link
Contributor Author

@Nageshbansal Nageshbansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests for create_socrata_datasets and create_rdataset , increase coverage by ~4%

@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #1645 (e2319e6) into main (15a529c) will increase coverage by 4.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1645      +/-   ##
==========================================
+ Coverage   60.23%   65.14%   +4.90%     
==========================================
  Files          43       43              
  Lines        4117     4117              
==========================================
+ Hits         2480     2682     +202     
+ Misses       1637     1435     -202     
Impacted Files Coverage Δ
retriever/lib/engine.py 81.25% <0.00%> (+0.27%) ⬆️
retriever/lib/scripts.py 66.95% <0.00%> (+11.68%) ⬆️
retriever/lib/socrata.py 83.10% <0.00%> (+23.64%) ⬆️
retriever/lib/rdatasets.py 74.80% <0.00%> (+28.24%) ⬆️
retriever/lib/create_scripts.py 46.23% <0.00%> (+31.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15a529c...e2319e6. Read the comment docs.

@Nageshbansal Nageshbansal changed the title Add tests for increasing code coverage Add tests for more code coverage Feb 12, 2022
@Nageshbansal
Copy link
Contributor Author

@henrykironde can you please review this PR.

@henrykironde
Copy link
Contributor

This is good, there are some changes that we should make. Let's go through this together when you get free time.

@Nageshbansal
Copy link
Contributor Author

Yeah sure.
Thanks

@henrykironde
Copy link
Contributor

This is not yet updated as we discussed.

@henrykironde henrykironde merged commit 0c4ed84 into weecology:main Apr 26, 2022
@Nageshbansal Nageshbansal deleted the coverage_tests branch May 4, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve test coverage
2 participants