-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for more code coverage #1645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests for create_socrata_datasets and create_rdataset , increase coverage by ~4%
Codecov Report
@@ Coverage Diff @@
## main #1645 +/- ##
==========================================
+ Coverage 60.23% 65.14% +4.90%
==========================================
Files 43 43
Lines 4117 4117
==========================================
+ Hits 2480 2682 +202
+ Misses 1637 1435 -202
Continue to review full report at Codecov.
|
@henrykironde can you please review this PR. |
This is good, there are some changes that we should make. Let's go through this together when you get free time. |
Yeah sure. |
This is not yet updated as we discussed. |
Fixes #1637