sqlite2csv #1467
Closed
sqlite2csv #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why do we have many commits? |
ashishpriyadarshiCIC
force-pushed
the
sql2csv
branch
from
9527f6b
to
c8217cd
Compare
| @@ -131,6 +134,17 @@ def json2csv(input_file, output_file=None, header_values=None, encoding=ENCODING | |||
| subprocess.call(['rm', '-r', input_file]) | |||
| return output_file | |||
|
|
|||
| def sqlite2csv(database): | |||
There was a problem hiding this comment.
Follow PEP8: https://www.python.org/dev/peps/pep-0008/
There was a problem hiding this comment.
Will do @apoorvaeternity 👍
There was a problem hiding this comment.
@apoorvaeternity Should I check my changes if following PEP8 using pycodestyle?
There was a problem hiding this comment.
@apoorvaeternity Sorry, Didn't know pycodestyle was the replacement for PEP8 in future Python releases. Made the changes in the code according to PEP8.
ashishpriyadarshiCIC
changed the title
ashishpriyadarshiCIC
force-pushed
the
sql2csv
branch
from
b3e8d1e
to
8fbffc7
Compare
ashishpriyadarshiCIC
force-pushed
the
sql2csv
branch
from
8fbffc7
to
4e74d16
Compare
|
Ref: #1505 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.