xls2csv #1480
xls2csv #1480
Conversation
ashishpriyadarshiCIC
force-pushed
the
xls2csv
branch
from
e6c54e6
to
0bd0424
Compare
retriever/lib/engine_tools.py
Outdated
| dire = book.rstrip(".xlsx") | ||
| if not os.path.exists(dire): | ||
| os.makedirs(dire) | ||
| else: |
There was a problem hiding this comment.
I was using it just to remove path already exists error, I'll remove it by adding exist_ok=True
retriever/lib/engine_tools.py
Outdated
| pass | ||
| os.chdir(dire) | ||
| res = len(workbook.sheet_names()) | ||
| for sheet in range(0, res): |
There was a problem hiding this comment.
I think we can omit the 0 and just use range(res).
retriever/lib/engine_tools.py
Outdated
| for index in range(worksheet.nrows): | ||
| df.loc[len(df)] = worksheet.row_values(1) | ||
| table_name = workbook.sheet_names() | ||
| df.to_csv(table_name[sheet] + '.csv', index_label='index') |
There was a problem hiding this comment.
We can make use of python f-strings here.
retriever/lib/engine_tools.py
Outdated
| df.loc[len(df)] = worksheet.row_values(1) | ||
| table_name = workbook.sheet_names() | ||
| df.to_csv(table_name[sheet] + '.csv', index_label='index') | ||
| os.chdir("..") |
There was a problem hiding this comment.
Is there a cleaner way to do this? I am not sure if this will always be compatible across different OS - it maybe. If we can pass the absolute path in os.chdir() somehow that would be great.
|
@ashishpriyadarshiCIC Any updates on this? |
| @@ -162,6 +164,21 @@ def xml2csv(input_file, outputfile=None, header_values=None, row_tag="row"): | |||
| return outputfile | |||
|
|
|||
|
|
|||
| def xlsxcsv(book): | |||
There was a problem hiding this comment.
The name should be xslx2csv to be consistent with other functions. Also, worth adding some comments to the code here.
|
Hi @apoorvaeternity, I just shifted all the work on Xlsx to CSV conversion function to #1506 |
|
Ref: #1506 |
xls to CSV conversion function