Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for empty version string #1674

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added check for empty version string #1674

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b82b461
Added check for empty version string
dikwickley Nov 6, 2023
41540fb
Used .strip()
dikwickley Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion retriever/lib/scripts.py
View file
Open in desktop
Expand Up @@ -29,7 +29,7 @@ def check_retriever_minimum_version(module):
m = module.name

if hasattr(module, "retriever_minimum_version"):
if not parse_version(VERSION) >= parse_version("{}".format(mod_ver)):
if mod_ver.strip() and not parse_version(VERSION) >= parse_version("{}".format(mod_ver)):
print("{} is supported by Retriever version "
"{}".format(m, mod_ver))
print("Current version is {}".format(VERSION))
Expand Down