Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for dashboard script #10

Merged
merged 8 commits into from Jun 27, 2018

Conversation

apoorvaeternity
Copy link
Member

No description provided.

@henrykironde henrykironde changed the title [WIP] Add tests for dashboard script Add tests for dashboard script Jun 1, 2018
@henrykironde
Copy link
Contributor

"contains_pk":"True"
},
"url":"https://raw.githubusercontent.com/apoorvaeternity/sample-dataset/master/original/Portal_rodents_19772002.csv",
"name":"main",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shall have to add the data first so that the url is from master instead of what you used.
https://raw.githubusercontent.com/apoorvaeternity/sample-dataset/master/original/Portal_rodents_19772002.csv
This data should be in a data directory somewhere, most probably in the test directory.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I will send a PR to add this data in the test directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data is up on master

@apoorvaeternity
Copy link
Member Author

@henrykironde How does it look now?

.travis.yml Outdated
- retriever ls
- cd retrieverdash/tests/
- pytest test_dashboard_script.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a -v pytest test_dashboard_script.py -v for verbose output

@@ -0,0 +1,171 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it is installing the original data. In that case, why don't you use retriever to install the original data. I may be missing something.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retriever is being used for installing the original as well as the modified data.

@henrykironde
Copy link
Contributor

Use this reference: https://pytest-django.readthedocs.io/en/latest/

@henrykironde henrykironde merged commit 5d4a12e into weecology:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants