New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for dashboard script #10
Add tests for dashboard script #10
Conversation
5d7e4a6
to
16e2183
Compare
|
"contains_pk":"True" | ||
}, | ||
"url":"https://raw.githubusercontent.com/apoorvaeternity/sample-dataset/master/original/Portal_rodents_19772002.csv", | ||
"name":"main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shall have to add the data first so that the url is from master instead of what you used.
https://raw.githubusercontent.com/apoorvaeternity/sample-dataset/master/original/Portal_rodents_19772002.csv
This data should be in a data directory somewhere, most probably in the test directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I will send a PR to add this data in the test directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data is up on master
3073aad
to
8013717
Compare
8013717
to
7cd4e07
Compare
@henrykironde How does it look now? |
.travis.yml
Outdated
- retriever ls | ||
- cd retrieverdash/tests/ | ||
- pytest test_dashboard_script.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a -v
pytest test_dashboard_script.py -v
for verbose output
@@ -0,0 +1,171 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it is installing the original data. In that case, why don't you use retriever to install the original data. I may be missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retriever is being used for installing the original
as well as the modified
data.
Use this reference: https://pytest-django.readthedocs.io/en/latest/ |
No description provided.