Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for dashboard script #10

Merged
merged 8 commits into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@apoorvaeternity
Copy link
Member

commented May 29, 2018

No description provided.

@apoorvaeternity apoorvaeternity force-pushed the apoorvaeternity:test_dashboard branch from 5d7e4a6 to 16e2183 May 30, 2018

@apoorvaeternity apoorvaeternity requested a review from henrykironde Jun 1, 2018

@henrykironde henrykironde changed the title [WIP] Add tests for dashboard script Add tests for dashboard script Jun 1, 2018

@henrykironde

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2018

"contains_pk":"True"
},
"url":"https://raw.githubusercontent.com/apoorvaeternity/sample-dataset/master/original/Portal_rodents_19772002.csv",
"name":"main",

This comment has been minimized.

Copy link
@henrykironde

henrykironde Jun 1, 2018

Contributor

We shall have to add the data first so that the url is from master instead of what you used.
https://raw.githubusercontent.com/apoorvaeternity/sample-dataset/master/original/Portal_rodents_19772002.csv
This data should be in a data directory somewhere, most probably in the test directory.

This comment has been minimized.

Copy link
@apoorvaeternity

apoorvaeternity Jun 1, 2018

Author Member

Okay I will send a PR to add this data in the test directory.

This comment has been minimized.

Copy link
@henrykironde

henrykironde Jun 1, 2018

Contributor

The data is up on master

@apoorvaeternity apoorvaeternity force-pushed the apoorvaeternity:test_dashboard branch from 3073aad to 8013717 Jun 2, 2018

@apoorvaeternity apoorvaeternity force-pushed the apoorvaeternity:test_dashboard branch from 8013717 to 7cd4e07 Jun 2, 2018

@apoorvaeternity

This comment has been minimized.

Copy link
Member Author

commented Jun 2, 2018

@henrykironde How does it look now?

.travis.yml Outdated
- retriever ls
- cd retrieverdash/tests/
- pytest test_dashboard_script.py

This comment has been minimized.

Copy link
@henrykironde

henrykironde Jun 2, 2018

Contributor

Add a -v pytest test_dashboard_script.py -v for verbose output

@@ -0,0 +1,171 @@
{

This comment has been minimized.

Copy link
@henrykironde

henrykironde Jun 2, 2018

Contributor

This looks like it is installing the original data. In that case, why don't you use retriever to install the original data. I may be missing something.

This comment has been minimized.

Copy link
@apoorvaeternity

apoorvaeternity Jun 2, 2018

Author Member

Retriever is being used for installing the original as well as the modified data.

@henrykironde

This comment has been minimized.

Copy link
Contributor

commented Jun 3, 2018

apoorvaeternity added some commits Jun 4, 2018

@henrykironde henrykironde merged commit 5d4a12e into weecology:master Jun 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.