Upgrade deps #95
Merged
Upgrade deps #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laodaniel
commented
Apr 22, 2024
| @@ -2,7 +2,9 @@ const { execute } = require('../../entities/route'); | |||
| const WorkflowError = require('../../entities/WorkflowError'); | |||
|
|
|||
| const step = jest.fn((container) => container); | |||
| const asyncStep = jest.fn((container) => new Promise((resolve) => resolve(container))); | |||
| const asyncStep = jest.fn((container) => new Promise((resolve) => { | |||
There was a problem hiding this comment.
This is because of eslint upgrade https://eslint.org/docs/latest/rules/no-promise-executor-return
eliasMC89
approved these changes
Apr 22, 2024
joaquin-alonso
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request relates to https://github.com/weekendesk/tech-management/issues/826 and #94
Scope
For the third party cookies phase out we need partitioned cookies to avoid third party cookie to be blocked.
Solution
Upgrade Express version. (Actual version is Express 4.17 it uses an old version of cookie lib which doesn’t support partitioned option). From version 4.19 we can use partitioned cookies.