Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On a CannotCalculate exception, xtype processing should stop and an appropriate value returned #929

Merged
merged 3 commits into from
Feb 11, 2024
Merged

On a CannotCalculate exception, xtype processing should stop and an appropriate value returned #929

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f381cd8
catch the CannotCalculate and 'say' the observation does not have any…
bellrichm Feb 4, 2024
cb39691
Merge branch 'weewx:master' into CannotCalculateFinal
bellrichm Feb 9, 2024
37bdc15
Merge branch 'weewx:master' into CannotCalculateFinal
bellrichm Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/weewx/xtypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,8 @@ def has_data(obs_type, timespan, db_manager):
return True
except (weewx.UnknownType, weewx.UnknownAggregation):
pass
except weewx.CannotCalculate:
return False
# Tried all the get_aggregates() and didn't find a non-null value. Either it doesn't exist,
# or doesn't have any data
return False
Expand Down