This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Feature: Use camera of iPhone to take pictures from inside app #64

Merged

mltbnz merged 12 commits into weg-li:develop from MergeConfllict:developYV

Aug 8, 2022

Contributor

MergeConfllict commented Jul 20, 2022

Additionally: Fix some typos

Riesenpferd added 6 commits

July 2, 2022 20:58


          Fix typos

a0adeef


          Make DescriptionFeatureApp and SettingsFeatureApp compile again

d50324b


          Fix typos

ab2a79b


          On ReportView: Show Date Widget after Photos Widget

a0fc57e


          Fix typo in unit tests

8ae3029


          Feature: Take photo from inside app using iPhone camera

97a97c8

mltbnz reviewed

View reviewed changes

DescriptionFeatureApp/DescriptionFeatureAppApp.swift Show resolved Hide resolved

mltbnz reviewed

View reviewed changes

WegliKit/Sources/ImagesFeature/ImagesCore.swift Show resolved Hide resolved

mltbnz reviewed

View reviewed changes

WegliKit/Sources/ImagesFeature/ImagesView.swift Show resolved Hide resolved

mltbnz reviewed

View reviewed changes

WegliKit/Sources/CameraAccessClient/Live.swift Outdated Show resolved Hide resolved

mltbnz reviewed

View reviewed changes

WegliKit/Sources/ImagesFeature/ImagesCore.swift

                   default:
                     return .none
                   }
+                case .takePhotosButtonTapped:

Member

mltbnz Jul 24, 2022

would be nice to have small test for the feature. If you need any assist let me know

Contributor Author

MergeConfllict Jul 29, 2022

I hope to find some time soon to add tests.

mltbnz reviewed

View reviewed changes

Member

mltbnz left a comment

in general looks very good 👍 some minor things and it would be nice to have a small test

mltbnz reviewed

View reviewed changes

WegliKit/Sources/ImagesFeature/ImagesView.swift Outdated Show resolved Hide resolved

WegliKit/Sources/ImagesFeature/CameraView.swift Show resolved Hide resolved

WegliKit/Sources/ImagesFeature/CameraView.swift Outdated Show resolved Hide resolved


          Update WegliKit/Sources/CameraAccessClient/Live.swift

d57f1aa

Co-authored-by: Malte Bünz <maltebuenz@posteo.de>

mltbnz suggested changes

View reviewed changes

Member

mltbnz left a comment

The tests currently fail since the cameraAccessClient is not set in the ImagesViewEnvironment constructor in ImagesStoreTests.swift
Unit test the new feature
add GeoLocation to the photo

Riesenpferd added 5 commits

August 7, 2022 20:25


          Fix unit tests

d332ae7


          Use asynch instead of Combine in CameraAccessClient

674b352


          Add unit tests fore camera feature

90e7a47


          Add coordinates to PickerImageResult after taking a photo using the c…

e33b16d

…amera


          Make camera button first option

7b42490

mltbnz approved these changes

View reviewed changes

Member

mltbnz left a comment

👍
Thanks for the work

mltbnz merged commit c206b6b into weg-li:develop

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.