Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config-file location #98

Closed
JakobMiksch opened this issue Jan 30, 2020 · 3 comments
Closed

Config-file location #98

JakobMiksch opened this issue Jan 30, 2020 · 3 comments
Assignees

Comments

@JakobMiksch
Copy link
Collaborator

Currently the config file must be placed in the static folder, whereas the rest of application-specific code is located in app.

Therefore, it would be clearer to also move the config file to the app folder. Ideally the init:app script should create this initial config file. So, the user can immediately start the application.

@justb4
Copy link
Collaborator

justb4 commented Mar 22, 2020

Agree, there is also issues with merging upstream into a clone. Possibly main.js could first look in app and then static for a config as a saw in @chrismayer branch: https://github.com/chrismayer/wegue/blob/app-fldr-conf/src/main.js#L47.

Placing a starter config under app/ could be also something init:app could do...

@chrismayer
Copy link
Collaborator

chrismayer commented Mar 23, 2020

Yes, the development in https://github.com/chrismayer/wegue/blob/app-fldr-conf/src/main.js#L47 is based on this issue. I should have pulled it to me. Done by now 😉

Placing a starter config under app/ could be also something init:app could do...

That was the plan as described by @JakobMiksch in the initial description of the issue: "Ideally the init:app script should create this initial config file. So, the user can immediately start the application". So it gets a "round" thing.

@chrismayer chrismayer self-assigned this Mar 23, 2020
justb4 added a commit to justb4/wegue that referenced this issue May 24, 2020
chrismayer added a commit that referenced this issue May 25, 2020
PR for #98 app-specific config file location under app/
justb4 added a commit to Geolicious/wegue that referenced this issue May 27, 2020
Fix wegue-oss#97 fix LayerList auto-update on permalink with ol-map-rendered-event

Plus solved some more issues with event-handling and unfolding tag/category nodes for visible layers. With/without applying permalink.
@justb4
Copy link
Collaborator

justb4 commented Nov 1, 2020

Think we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants