Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geodata file map drag/drop #155

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Conversation

chrismayer
Copy link
Collaborator

@chrismayer chrismayer commented Dec 10, 2020

This adds support for geodata file drag/drop to the map as described in #99. Supported formats are GeoJSON, KML, GPX, IGC and TopoJSON. By adding the following config option the functionality can be enabled for your Wegue app:

  // ...
  "mapGeodataDragDop": {
    "formats": ["GeoJSON", "KML"],
    "zoomToData": false,
    "replaceData": true,
    "displayInLayerList": true,
    "layerName": "Uploaded Data"
  },
  // ...

Please review @justb4 and @JakobMiksch (and of course anybody else who is willing to review).

This adds support for geodata file drag/drop to the map as described in
@chrismayer chrismayer changed the title WIP: Map Drag Drop Geodata file map drag/drop Dec 11, 2020
@JakobMiksch
Copy link
Collaborator

@chrismayer I tested it and it works like expected. Code looks fine as well. It is ready to merge from my side.

@chrismayer
Copy link
Collaborator Author

Thanks for the review @JakobMiksch. I'll address the suggestions of @justb4 posted in #99 (comment):

  • sometimes it is an option to replace the data i.s.o. adding to the Layer, but you would need user-interaction or a config option
  • is it an idea to show the added Layer in the LayerList? As config option (displayInLayerList, now hardcoded false). One could also configure the Layer name.

And then it should be good to go.

@justb4
Copy link
Collaborator

justb4 commented Dec 16, 2020

Ok, tested, fine to merge.

@JakobMiksch
Copy link
Collaborator

I tested it again, and it works well. Ready to merge.

@chrismayer
Copy link
Collaborator Author

Thank you for the reviews! I'll merge now.

@chrismayer chrismayer merged commit 183e581 into wegue-oss:master Dec 16, 2020
@chrismayer chrismayer deleted the 99-map-dragdrop branch December 16, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants