#83 add Dockerfile with some docu in README #84
Conversation
There was a problem hiding this comment.
This is very cool and works great! 👍 Thank you very much @justb4!
I have some minor remarks, you might want to address at will. Otherwise we can do them follow-ups.
| To run with a custom Wegue JSON config, use Docker Volume Mapping to override the default config: | ||
|
|
||
| ``` bash | ||
| docker run -it -p 8080:80 -v $(pwd)/app-conf-mine.json:/usr/share/nginx/html/static/app-conf.json meggsimum/wegue:latest |
There was a problem hiding this comment.
By mapping app-conf-mine.json to static/app-conf.json it will overwrite the default app-conf. By setting
-v $(pwd)/app-conf-mine.json:/usr/share/nginx/html/static/app-conf-mine.json you could use both the default configs and the newly mounted one by http://localhost:8080/?appCtx=mine
There was a problem hiding this comment.
True, but idea was that in real-world cases one would add own config, override default, thus keep URL simple (no appCtx=).
There was a problem hiding this comment.
hold on, a double bash literal now in README.md text, will commit in few seconds....
There was a problem hiding this comment.
OK, totally fine with that. Always good to have several options.
Co-Authored-By: Christian Mayer <chris@meggsimum.de>
|
Ok, updated |
|
Thanks again @justb4 ! I'll happily merge now. |
Added
Dockerfile(Image size uncompressed just 32.3MB) plus some guidance inREADME.md.Tested with custom app-config and Docker Volume Mapping.