Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: style embed message #22

Closed
wants to merge 2 commits into from
Closed

style: style embed message #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99ea300
style: style embed message
wei Nov 25, 2020
cb0c798
style: add links to GitHub handles
wei Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 26 additions & 10 deletions webhook/helpers.js
View file
Open in desktop
Expand Up @@ -22,7 +22,7 @@ async function prepareMessage({ payload, githubProject }) {
let prevColumn = null;
let cardState = 'card';
const firstLine = description.split(/\n+/)[0];
let title = `[${toPascalCase(action)}] ${firstLine}`;
let title = `\`[${toPascalCase(action)}]\` ${firstLine}`;
description = description.replace(firstLine, '').trim();
const column = await getProjectCardColumn(project_card.column_id);
let issue = null;
Expand All @@ -40,7 +40,7 @@ async function prepareMessage({ payload, githubProject }) {
cardState = await getCardState(issue, pullRequest);
const issueRepo = `${detectedIssue.owner}/${detectedIssue.repo}`;
const repoPrefix = issueRepo !== repoFullName ? issueRepo : '';
title = `[${toPascalCase(action)}] ${repoPrefix}#${issue.number}\n${issue.title}`;
title = `\`[${toPascalCase(action)}]\` ${repoPrefix}#${issue.number}\n${issue.title}`;
description = project_card.note || '';
if (!description) {
description = (issue.body || '').trim();
Expand All @@ -54,7 +54,7 @@ async function prepareMessage({ payload, githubProject }) {

let embed = new MessageEmbed()
.setTitle(title)
.setDescription(description)
.setDescription(addLinksToGitHubHandles(description))
.setURL(`${githubProjectUrl}#card-${project_card.id}`)
.setColor(getColor(action))
.setThumbnail(getThumbnail(cardState))
Expand All @@ -66,9 +66,9 @@ async function prepareMessage({ payload, githubProject }) {
prevColName: prevColumn ? `[${prevColumn.name}](${githubProjectUrl}#column-${prevColumn.id})` : undefined,
colName: column ? `[${column.name}](${githubProjectUrl}#column-${column.id})` : '-',
created: project_card.creator
? `[@${project_card.creator.login}](https://github.com/${project_card.creator.login}) on ${project_card.created_at.substr(0, 10)}` : '-',
assignees: (issue && issue.assignees || []).map(a => `[@${a.login}](https://github.com/${a.login})`).join('\n'),
reviewers: (pullRequest && pullRequest.requested_reviewers || []).map(r => `[@${r.login}](https://github.com/${r.login})`).join('\n'),
? `@${project_card.creator.login} on ${project_card.created_at.substr(0, 10)}` : '-',
assignees: (issue && issue.assignees || []).map(a => `@${a.login}`).join('\n'),
reviewers: (pullRequest && pullRequest.requested_reviewers || []).map(r => `@${r.login}`).join('\n'),
labels: (issue && issue.labels || []).map(l => `\`${l.name}\``).join(' '),
};
embed = setEmbedFields(embed, embedFields);
Expand All @@ -92,12 +92,24 @@ function setEmbedFields(embed, { prevColName, colName, created, assignees, revie
);
}

if (assignees || reviewers) {
if (assignees && reviewers) {
embed = embed
.addFields(
{ name: 'Reviewers', value: reviewers || '-', inline: true },
{ name: 'Reviewers', value: addLinksToGitHubHandles(reviewers), inline: true },
{ name: '\u200B', value: '\u200B', inline: true },
{ name: 'Assignees', value: assignees || '-', inline: true },
{ name: 'Assignees', value: addLinksToGitHubHandles(assignees), inline: true },
);
}
else if (assignees) {
embed = embed
.addFields(
{ name: 'Assignees', value: addLinksToGitHubHandles(assignees) },
);
}
else if (reviewers) {
embed = embed
.addFields(
{ name: 'Reviewers', value: addLinksToGitHubHandles(reviewers) },
);
}

Expand All @@ -110,7 +122,7 @@ function setEmbedFields(embed, { prevColName, colName, created, assignees, revie

embed = embed
.addFields(
{ name: 'Created', value: created },
{ name: 'Created', value: addLinksToGitHubHandles(created) },
);

return embed;
Expand Down Expand Up @@ -153,6 +165,10 @@ function detectProjectCardIssue(project_card) {
return null;
}

function addLinksToGitHubHandles(s) {
return s.replace(/@([a-zA-Z0-9-]+)/g, (handle, username) => `[${handle}](https://github.com/${username})`);
}

module.exports = {
prepareMessage,
};