Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Issues" badge should only include "open" issues #75

Closed
impressivewebs opened this issue Nov 5, 2020 · 5 comments · Fixed by #76
Closed

"Issues" badge should only include "open" issues #75

impressivewebs opened this issue Nov 5, 2020 · 5 comments · Fixed by #76
Labels
discussion Open for community discussion feature-request A request for a new feature

Comments

@impressivewebs
Copy link

Great tool!

Currently, when selecting the "issues" checkbox, it includes all issues, including ones that have been closed. It seems it would be much better to include only the "open" issues. Does the GitHub API allow that instead of all issues?

@CryogenicPlanet CryogenicPlanet added feature-request A request for a new feature discussion Open for community discussion labels Nov 5, 2020
@CryogenicPlanet
Copy link
Collaborator

@impressivewebs Yes the Github API does support and we can achieve this by changing the graphql.

I would like to leave this open for discussion for the community and @wei to see which would be a better fit for projects, but it should be a pretty trivial change to make.

Note to self:
Change the following lines too and regenerate relay

issues {
totalCount
}

 issues(states: OPEN) {
      totalCount
    }

@impressivewebs
Copy link
Author

Yeah, I definitely think it would be better with only open issues. As an example, if you were including a big project like React it would list almost 10,000 "issues", which isn't accurate at all, since the actual "open" issues are only about 480.

Just my two cents. Thanks for the quick response!

@wei
Copy link
Owner

wei commented Nov 6, 2020

I agree, I say we do the same for the PRs too.

CryogenicPlanet added a commit that referenced this issue Nov 8, 2020
- Will now show only open pull requests and issues
@wei wei closed this as completed in #76 Nov 8, 2020
@impressivewebs
Copy link
Author

@CryogenicPlanet I just tested it, works great! This is much better.

@wei
Copy link
Owner

wei commented Nov 8, 2020

Thanks for the suggestion! Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open for community discussion feature-request A request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants