removed instance variable assignmnet, used directly in view

weichic-ncsu · Oct 26, 2022 · b5636bb · b5636bb
1 parent 4684f83
commit b5636bb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/app/controllers/signup_sheet_controller.rb b/app/controllers/signup_sheet_controller.rb
@@ -168,7 +168,6 @@ def compute_signed_up_topics
   def list
     @participant = AssignmentParticipant.find(params[:id].to_i)
     @assignment = @participant.assignment
-    @max_team_size = @assignment.max_team_size
     @signup_topics = SignUpTopic.where(assignment_id: @assignment.id, private_to: nil)
     @show_actions = true
     @priority = 0

diff --git a/app/views/signup_sheet/intelligent_topic_selection.html.erb b/app/views/signup_sheet/intelligent_topic_selection.html.erb
@@ -23,7 +23,7 @@
       <tbody id="topics"  class="connectedSortable">
       <tr class="sort-disabled"><td></td><td></td></tr>
       <% for topic in @signup_topics %>
-          <%= get_intelligent_topic_row(topic, @selected_topics, @max_team_size) %>
+          <%= get_intelligent_topic_row(topic, @selected_topics, @assignment.max_team_size) %>
           <% is_suggested_topic = false %>
           <%= render :partial => 'table_line', :locals => {:i=>i, :topic=>topic, :is_suggested_topic=>is_suggested_topic} %>
           </tr>
@@ -39,7 +39,7 @@
       <tbody id="selections" data-update-url=<%= "/signup_sheet/set_priority?participant_id=#{@participant.id}" %> class="connectedSortable">
         <tr class="sort-disabled"><td></td><td></td></tr>
         <% for topic in @bids %>
-          <tr style= "background-color:<%= get_topic_bg_color(topic, @max_team_size) %>" id="topic_<%= topic.id %>">
+          <tr style= "background-color:<%= get_topic_bg_color(topic, @assignment.max_team_size) %>" id="topic_<%= topic.id %>">
              <%= render :partial => 'table_line', :locals => {:i=>i, :topic=>topic, :is_suggested_topic=>is_suggested_topic} %>
           </tr>
           <% i=i+1 %>
@@ -58,4 +58,4 @@
     <a href="javascript:history.back()">Back</a>
     <br/>
   </div>
-</div>
+</div>