Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove constraint that zip64 field values be greater than 0 #319

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Remove constraint that zip64 field values be greater than 0 #319

wants to merge 1 commit into from

Commits on Apr 30, 2024

  1. Remove constraint that zip64 field values be greater than 0 

    In ZIP64 archives, certain standard field values (like file sizes and offsets within the archive) are set to 0xFFFFFFFF, and actual values are provided in the ZIP64 extra fields. The code was requiring these values be > 0. If a value was 0, the non-ZIP64 value was returned (0xFFFFFFFF), and thus almost guaranteed to be incorrect.

This patch removes that test for `compressedSize`, `uncompressedSize`, and `relativeOffsetOfLocalHeader`. While it’s unlikely for a file to have zero length, it’s not impossible, and it’s very likely for a local header to be at offset 0.
    @JetForMe
    JetForMe committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    a5f7263 View commit details
    Browse the repository at this point in the history