Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test namespace within CryptoPP namespace #379

Closed
noloader opened this issue Feb 21, 2017 · 1 comment
Closed

Add Test namespace within CryptoPP namespace #379

noloader opened this issue Feb 21, 2017 · 1 comment

Comments

@noloader
Copy link
Collaborator

noloader commented Feb 21, 2017

On occasion users will ask about missing symbols in the library, like GlobalRNG(). It has come up on several occasions, including Stack Overflow and the User Group.

The problem appears to stem from creating a project with an external build system (like CodeBlocks, Eclipse or Xcode), and adding all the header and source files to the project. On our side, its not readily apparent a symbol like GlobalRNG() is part of Testing and Evaluation.

At this point, we are going to keep the code in regtest.cpp out of Test::. The functions are used for an object registry, and they are useful to the library and testing. In the future, we will make more use of it when the Engine like interface gets cut-in.

This bug report tracks the addition of a Test:: namespace within CryptoPP:: namespace.


Adding the namespace is just maintenance work. There's no thinking required. At the same time, we will pull GCC's deprecated warning suppression (no longer needed), and USING_NAMESPACE(std) (no longer needed for most files). Its more mindless work.

@noloader
Copy link
Collaborator Author

Also see Commit 73836e58a5f5c11c and Test namespace within CryptoPP namespace on the mailing list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant