Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NULL_CHANNEL and Code Warrior 8 workaround #382

Closed
noloader opened this issue Mar 1, 2017 · 1 comment
Closed

Remove NULL_CHANNEL and Code Warrior 8 workaround #382

noloader opened this issue Mar 1, 2017 · 1 comment

Comments

@noloader
Copy link
Collaborator

noloader commented Mar 1, 2017

BufferedTransformation includes the following:

class BufferedTransformation : public Algorithm, public Waitable
{
public:
    // placed up here for CW8, same as DEFAULT_CHANNEL, for backwards compatibility
    static const std::string &NULL_CHANNEL;
    ...
};

NULL_CHANNEL dates back to the Crypto++ 4.0 (and earlier) days. In addition, Code Warrior 8 is older than the .Net compilers we support. Finally, NULL_CHANNEL contributes to Static Initialization Order Fiasco.

For the upcoming Crypto++ 6.0 release, we will remove the deprecated channel name and Code Warrior support.

@noloader
Copy link
Collaborator Author

noloader commented Mar 1, 2017

Cleared at Commit 5fb2f5d45b9bb2cd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant