Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of errata items to be fixed before release #58

Closed
noloader opened this issue Nov 5, 2015 · 6 comments
Closed

Rollup of errata items to be fixed before release #58

noloader opened this issue Nov 5, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@noloader
Copy link
Collaborator

noloader commented Nov 5, 2015

These are the issues we are aware that should be fixed prior to 5.6.3 release. They were reported after RC6 (give or take...). We are tracking them under a single bug report.

  • Guard CRYPTOPP_CXX11_ALIGNOF on MSC 1900
  • cryptest.exe tv all does not run HKDF tests. Need to add hkdf.txt to all.txt.
  • "... to the ABI and ABI""... to the ABI and API" in Readme.txt.
  • MinGW and error: 'memcpy_s' was not declared in this scope. Cleared with a using CryptoPP::memcpy_s;
  • MinGW and rdrand detection. Investigating.
  • Remove unneeded -Wno-unused-function -Wno-unused-parameter -Wno-unused-variable from GNUmakefile-cross.
  • Change GNUmakefile's make docs recipe to use ref<Version> as the output directory.
  • Change GNUmakefile's to avoid -fPIC for MinGW.
  • Remove CRYPTOPP_DISABLE_SHA_ASM from sha.h and sha.cpp. Its an artifact from earlier testing.
  • Issue 64: PolynomialMod2::operator<<= Bug - fixed the reg.Grow(...) logic
  • Issue 24: Compiler warnings on GCC and MinGW - cleared the longmp warning
@Zireael-N
Copy link
Contributor

I don't think these two are worth a bug report of their own:

misc.h needs a s/Desitnation/Destination/g & s/satsify/satisfy/g:
misc.h#L220

  • the same comment in memmove_s() @ L249.

@noloader
Copy link
Collaborator Author

noloader commented Nov 6, 2015

If those are the only two you found, then I'm happy :)

My spelling and grammar is horrible at times....

@Zireael-N
Copy link
Contributor

Also noticed the need of s/desination/destination/g at L207, L208, L236 and L237.

I wasn't really looking for typos, it's just #28 made me spend a lot of time around memcpy_s(). :S

@noloader
Copy link
Collaborator Author

noloader commented Nov 8, 2015

@Zireael-N, Have you spotted anything else that needs attention?

I'm getting ready to test RDRAND and RDSEED changes. Once they are successful, then the roll-up will be checked in.

@Zireael-N
Copy link
Contributor

Have you spotted anything else that needs attention?

No, I haven't.

@noloader
Copy link
Collaborator Author

Cleared at check-in d2fda9b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants