-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate Container/Set #15
Conversation
f0ea6a8
to
9de0661
Compare
Implement HashSet::union()In the last commit (caab7fb) I implemented
and it works To achieve this, I had to derive |
@choznerol Nice try. Here are my opinions concerning binding First, to be a generic container type, Second, creating a new
All these methods can cope with the Last, you can still decide to bind These commits are still awesome attempts. Great job! |
@weihanglo Thanks for the detail explanation! I did feel something weird when adding I also peeked at On the other hand, I could still mention the first implementation in the chapter (updated in the dract) to demostrate how that can be refactored in a more 'rust' way (thanks to the explaination above!). |
A step-by-step guide is highly appreciated. It would be a great experience to walk through implementation details with such a veteran Rust developer. |
This reverts commit caab7fb.
cf910d1
to
f6ebde2
Compare
Co-authored-by: weihanglo <weihanglo@users.noreply.github.com> Co-authored-by: choznerol <lawrencechou1024@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Would be merged.
Will close part of #4
The code implementation (
set/mod.rs
) will be push/rebase in thie branch. Besides the code, the draft will be edit in HackMD before ready to publish. Please feel free to add/suggest good topics to cover!馃憠https://hackmd.io/VsM13vR1TrKzVRsKpHuTjA?both