Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reproduce 10th_neighbors.txt #2

Open
ThibaultGROUEIX opened this issue May 26, 2020 · 0 comments
Open

Cannot reproduce 10th_neighbors.txt #2

ThibaultGROUEIX opened this issue May 26, 2020 · 0 comments

Comments

@ThibaultGROUEIX
Copy link

Hi @weihua916,
Thanks for the code release.
To run calculate_distance.py, I had to replace mnist = fetch_mldata('MNIST original', data_home=PATH) by mnist = fetch_openml('mnist_784') since fetch_mldata is deprecated. Note that this should not affect the data at all.

I cannot reproduce 10th_neighbors.txt
The first values of the file I generated are :
1.260706806182861328e+01 9.380294799804687500e+00 1.302325439453125000e+01 4.264658927917480469e+00 9.928882598876953125e+00 1.266661167144775391e+01 4.756112575531005859e+00 1.012734127044677734e+01 4.143903255462646484e+00 9.276198387145996094e+00

The problem is that your method is less stable with these values. Here are 10 runs :
0.98, 0.98, 0.91, 0.88, 0.87, 0.98, 0.98, 0.91, 0.96, 0.86.

Can you make sure that calculate_distance.py generates your own 10th_neighbors.txt or update the depo?
Thanks for you time and help,
Thibault

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant