Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross join implementation has incorrect description of _tableRows #1

Closed
TylerBrock opened this issue Nov 30, 2021 · 1 comment
Closed

Comments

@TylerBrock
Copy link

Hey I was just reading through the excellent wiki you've made and I think the comment above row.tableRows = [x, y]; in CROSS_JOIN.md should be: // Store an array of the two rows used to make up this new row. instead of // Store an array of the two columns used to make up this new row.

I sadly don't think there is a way to make a PR against the wiki so I'm filing an issue instead. Cheers!

@weinberg
Copy link
Owner

Great catch. Yeah why can't you make a PR on a wiki? That should be a thing!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants