Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint in VS code broken after 1.6.1 upgrade #180

Closed
SirSKillz opened this issue Dec 22, 2022 · 2 comments
Closed

ESLint in VS code broken after 1.6.1 upgrade #180

SirSKillz opened this issue Dec 22, 2022 · 2 comments

Comments

@SirSKillz
Copy link

Current Behavior

Inside of VS code, eslint does not function if you extend the dts-cli as suggested in the README due to @typescript-eslint/eslint-plugin and @typescript-eslint/parser being removed from dependencies and moved into dev dependencies in b90cc74

Expected behavior

After creating the .eslintrc.js file as explained in the README, ESLint should function correctly inside of VS code. While it is common and an easy workaround to install these dependencies inside of our own projects, it should still function without doing so.

Suggested solution(s)

Add both @typescript-eslint/eslint-plugin and @typescript-eslint/parser back to the dependencies of this project

Your environment

System:
    OS: Windows 10 10.0.19044
    CPU: (24) x64 AMD Ryzen 9 5900X 12-Core Processor
    Memory: 20.26 GB / 31.91 GB
  Binaries:
    Node: 16.17.1 - C:\Program Files\nodejs\node.EXE
    npm: 8.15.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: 108.0.5359.125
    Edge: Spartan (44.19041.1266.0), Chromium (108.0.1462.46)
    Internet Explorer: 11.0.19041.1566
  npmPackages:
    dts-cli: ^1.6.2 => 1.6.2
    typescript: ^4.9.4 => 4.9.4
@aladdin-add
Copy link

ah, my bad! will release a patch soon, thanks for the report! ❤️

@aladdin-add
Copy link

fixed in v1.6.3: https://github.com/weiran-zsd/dts-cli/releases/tag/v1.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants