Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias issue on build #88

Closed
The-Code-Monkey opened this issue Nov 8, 2021 · 3 comments
Closed

Alias issue on build #88

The-Code-Monkey opened this issue Nov 8, 2021 · 3 comments

Comments

@The-Code-Monkey
Copy link

Sorry to keep bombarding with issues, but i seem to have got an issue as where the aliases that work normally don't seem to work when running the built files.

https://github.com/The-Code-Monkey/Components/runs/4141119026?check_suite_focus=true

@aladdin-add
Copy link

where did you define the aliases? IMHO, you should not define the aliases in your lib, as it will force your users to apply the same aliases.

@aladdin-add
Copy link

well, I see. https://github.com/The-Code-Monkey/Components/blob/3cc972a9478b9eb96a55b87c5a8e8b8ef529638c/jestAliasResolver.js#L15-L31

the error was from size-limit - the aliases were only known by jest, but not size-limit.

@The-Code-Monkey
Copy link
Author

Do you know how to fix this as I thought it should just be picked up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants