Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When sharing, give option of sharing the content link or comments link #68

Closed
weiran opened this issue Jan 12, 2019 · 2 comments
Closed

When sharing, give option of sharing the content link or comments link #68

weiran opened this issue Jan 12, 2019 · 2 comments
Labels
enhancement
Milestone
4.1

Comments

@weiran
Copy link
Owner

weiran commented Jan 12, 2019

No description provided.

@weiran weiran added this to the 4.0 milestone Jan 12, 2019
@robbiet480 robbiet480 mentioned this issue May 17, 2019
Closed
@weiran weiran modified the milestones: 4.0, 4.1 Jun 15, 2019
@stevenreddie
Copy link

Suggestion: Instead of having to create some additional UI which also requires additional interaction for the user, perhaps make the Share button on the comments page share the comments link instead of the content link and leave the content page to share the content link as it currently does. This is how I intuitively thought it would work when I used both of these Share buttons.

@weiran
Copy link
Owner Author

weiran commented Sep 21, 2019

Great idea.

@weiran weiran modified the milestones: 4.2, 4.1 Sep 21, 2019
@weiran weiran closed this as completed in 2cc3fb3 Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
2 participants
@weiran @stevenreddie