Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide tab bar when navigating to comments on compact size classes #70

Closed
weiran opened this issue Jan 12, 2019 · 2 comments · Fixed by #173
Closed

Hide tab bar when navigating to comments on compact size classes #70

weiran opened this issue Jan 12, 2019 · 2 comments · Fixed by #173
Labels
enhancement
Milestone
4.4

Comments

@weiran
Copy link
Owner

weiran commented Jan 12, 2019

No description provided.

@weiran weiran added this to the 4.0 milestone Jan 12, 2019
@mzain512 mzain512 mentioned this issue May 15, 2019
Closed
@weiran
Copy link
Owner Author

weiran commented Jun 1, 2019

Tried to fix this in #96 but failed.
#99 also tried to fix it but it didn't animate and didn't work on iPads.

The problem here is the UITabBarController is the root with a UISplitViewController as a child. This should only try to hide the tab bar if the horizontal size class is compact (full screen push of comments). Otherwise it should be visible.

@weiran weiran changed the title Hide tab bar on comments view Hide tab bar when navigating to comments on compact size classes Jun 1, 2019
@weiran weiran modified the milestones: 4.0, 4.1 Jun 15, 2019
@weiran weiran modified the milestones: 4.2, 4.next May 2, 2020
@weiran weiran removed this from the 4.3 milestone Jun 5, 2020
@weiran
Copy link
Owner Author

weiran commented Jun 13, 2020

Thinking about removing the nav bar and replacing it with a segmented control for switching list type.

@weiran weiran added this to the 4.next milestone Jun 13, 2020
@weiran weiran mentioned this issue Jun 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.4
Development

Successfully merging a pull request may close this issue.

Improved post type navigation to replace tab bar weiran/Hackers
1 participant
@weiran