Skip to content

Commit

Permalink
Fix missing version in PHARs build on GA
Browse files Browse the repository at this point in the history
We were overriding the root version with COMPOSER_ROOT_VERSION, so all
PHARs had `dev-master` as the version for `vimeo/psalm` baked in.

Fixed vimeo#7606
  • Loading branch information
weirdan committed Dec 23, 2022
1 parent 5979579 commit 7dd25b4
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/build-phar.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ jobs:
coverage: none

- uses: actions/checkout@v3
with:
fetch-depth: 0 # required for composer to automatically detect root package version

- name: Get Composer Cache Directories
id: composer-cache
Expand All @@ -62,8 +64,9 @@ jobs:
- name: Run composer install
run: composer install -o
env:
COMPOSER_ROOT_VERSION: dev-master
# DO NOT set this, we need composer to figure out the version itself
# env:
# COMPOSER_ROOT_VERSION: dev-master

- run: bin/build-phar.sh
env:
Expand Down

0 comments on commit 7dd25b4

Please sign in to comment.