Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes #3

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Breaking changes #3

merged 4 commits into from
Feb 12, 2019

Conversation

weirdpattern
Copy link
Owner

This PR will:

@weirdpattern
Copy link
Owner Author

@IlyaSemenov and @pikax this PR should take care of both issues.
This will bump the version to 2.0 as it contains breaking changes.

I will appreciate if you take a look and let me know if this will work for you and the community.

.eslintignore Outdated Show resolved Hide resolved
.eslintignore Outdated Show resolved Hide resolved
.npmignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@weirdpattern
Copy link
Owner Author

@IlyaSemenov thanks for your comments.
I pushed new changes with your recommendations.
I will give you and others a few more days before I merge this and push a new version to npm.

@weirdpattern
Copy link
Owner Author

while I'm here, I will update the versions too...
I think there are new versions for typescript related files

@tarpier
Copy link
Contributor

tarpier commented Feb 11, 2019

Hey @weirdpattern thanks for the effort! This looks very promising, do you have a timeline to integrate this PR?

@weirdpattern
Copy link
Owner Author

Hi @tarpier I will merge and publish tonight.

@weirdpattern weirdpattern merged commit 5336480 into master Feb 12, 2019
@weirdpattern weirdpattern deleted the feat--split-prettier-support branch February 12, 2019 04:38
@weirdpattern
Copy link
Owner Author

Hey @tapier just published version 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typescript-eslint-parser is deprecated Why does typescript/prettier depend on typescript/react?
3 participants