-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS Auto settings is treated as dark mode #1
Comments
I'll have to look into it. I do not have a system with macOS installed myself. Basically the responsible code for the check is the following: NSString *interfaceStyle = [[NSUserDefaults standardUserDefaults] stringForKey:@"AppleInterfaceStyle"];
// interfaceStyle can be nil (light mode) or "Dark" (dark mode).
BOOL isDark = [VALUE_DARK caseInsensitiveCompare:interfaceStyle] == NSOrderedSame;
BOOL switchesAutomatically = [[NSUserDefaults standardUserDefaults] boolForKey:@"AppleInterfaceStyleSwitchesAutomatically"];
if (switchesAutomatically) {
// If switchesAutomatically == YES the roles of "Dark" and nil are changed.
return (jboolean) !isDark;
} If you run this on your machine does it yield the correct value? |
After doing some remote testing with a friends machine it seems as if the value of |
Could you try out if the new pre-release works as expected? |
Sure, I will do it first thing in the morning. |
In this release this issue is fixed. Thanks! |
I did some more research and apparently the Catalina |
I'm kind of getting conflicting information. For one there is this issue. The propsed solution is to use This issue also highlights a possible issue when powering off in dark mode and turning back in during daytime. I'll have to do more testing but as long as there is no |
@eugene-stativka Do you experience errors between restarts/sleep mode? |
So far, no but maybe I haven't covered all edge cases yet. I will let you know if I notice something |
For now the plugin behaves well. I'm using NightOwl to control the dark mode. I've tried :
IntelliJ 2020.1
|
@bric3 good to know 👍 I have released the current latest pre-release (should be available in 2/3 days). If any issues arise this issue can be reopened. |
I've set NightOwl mode sunrise / sunset, with lid closed in-between. Looks good ! |
Actually I think I encountered a bug.
Maybe I should log that in another issue. |
That is exactly the possible scenario that would break it I had in mind. I has to do with a weird behaviour of how |
Thank you for your great job!
I've tried 1.1.0-pre on MacOS 10.15.4 and it seems like
Auto
appearance setting is treated as dark mode even if it is not a late evening and light mode is automatically set by the operating system. Can you please check?The text was updated successfully, but these errors were encountered: