Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This method has some problem on MacOS 10.15 auto mode #1

Open
oyljerry opened this issue Sep 6, 2019 · 2 comments
Open

This method has some problem on MacOS 10.15 auto mode #1

oyljerry opened this issue Sep 6, 2019 · 2 comments

Comments

@oyljerry
Copy link

oyljerry commented Sep 6, 2019

Hi:
After tried your method to detect appearance, I have found some issue on MacOS 10.15 auto mode. Please check below reproduce scenario.
Assumption: Currently, it is time at 8:00 PM local time, and turn on Auto Mode, The Appearance is in dark mode.
The function now detect it dark mode (Correct), Now I go to "General", Switch "Appearance" to "Dark" mode, Then, I switch to "Auto" mode again, In this scenario, The function will get "UserDefaults(AppleInterfaceStyleSwitchesAutomatically)" to TRUE, and "UserDefaults(AppleInterfaceStyle)" to "Dark", so, It will detect theme to "Light", but currently, It is Dark in "Auto" mode, Please kindly check this issue. Thanks.

@PentonBin
Copy link

Hi:
After tried your method to detect appearance, I have found some issue on MacOS 10.15 auto mode. Please check below reproduce scenario.
Assumption: Currently, it is time at 8:00 PM local time, and turn on Auto Mode, The Appearance is in dark mode.
The function now detect it dark mode (Correct), Now I go to "General", Switch "Appearance" to "Dark" mode, Then, I switch to "Auto" mode again, In this scenario, The function will get "UserDefaults(AppleInterfaceStyleSwitchesAutomatically)" to TRUE, and "UserDefaults(AppleInterfaceStyle)" to "Dark", so, It will detect theme to "Light", but currently, It is Dark in "Auto" mode, Please kindly check this issue. Thanks.

hi oyljerry, have you solved this problem?

@tunabelly
Copy link

tunabelly commented Dec 13, 2019

@oyljerry @PentonBin this should be resolved by the fix from @ruiaureliano where it now checks the effective appearance on 10.15 instead of relying on the user defaults which can be incorrect. Check out this commit for the changes:

609bc9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants