enforce that logging system can only be bootstrapped once #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
force-pushed
the
fixes3
branch
3 times, most recently
from
81978a0
to
6ce579b
Compare
ktoso
reviewed
Jan 18, 2019
There was a problem hiding this comment.
A bit worried about this but perhaps we can start with it. I guess it is true that if we have racy setters of this then some library is misbehaving etc.
Always easier to lift restrictions rather than add them later after all.
+0 from me, I don't mind it tho :)
|
@weissi rebased |
tomerd
force-pushed
the
fixes3
branch
2 times, most recently
from
4ca4263
to
db856eb
Compare
|
@weissi rebased again |
motivation: safer logging system changes: do a precondition check to verify logging syste is only initialized/bootstrapped once per process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: safer logging system
changes: do a precondition check to verify logging syste is only initialized/bootstrapped once per process