Use AsyncConnectionWrapper with TLS connection

[DevLazio]

Hello,

I have been trying to use the newly release AsyncConnectionWrapper to run my migrations at the start of my program.
I may have missed something but it doesn't seem to be a way to get an AsyncConnectionWrapper with TLS capabilities : the only documented way to get an AsyncConnectionWrapper is through the establish() function, which only accept an URL and no config.
Predictably, the connection fail with "error performing TLS handshake: no TLS implementation configured".

Is there a way to add a TLS configuration or to wrap around a previously setup AsyncDieselConnectionManager ?

[weiznich]

To cite from the release announcement post:

Moreover, there are differences between the provided connection wrapper and existing diesel connection types in terms of functionality and behavior. These discrepancies include variations in handling database URL's, TLS configurations, and row streaming from the database. As a result the new connection type is not supposed to be a drop in replacement for existing diesel connection types.

So yes that's currently "expected" behavior and there is no other way to configure the TLS setup.
That written: I'm happy to accept PR's to add this feature, but I likely won't have the time to address this soon due to other issues. After all that's a request for a "new" feature, and I consider fixing existing bugs more important for now.

[weiznich]

To add some idea for a possibly accepted implementation here:

We could just add a generic TryFrom implementation for all async connections + all BlockOn types that implement Default.

[DevLazio]

Why not a simple From like that:

impl<C, B> From<C> for AsyncConnectionWrapper<C, B>
        where
            C: crate::AsyncConnection,
            B: BlockOn + Send,
    {
        fn from(inner: C) -> Self {
            Self {
                inner,
                runtime: B::get_runtime(),
            }
        }
    }

it seems to work fine for me.

[weiznich]

That would be also fine.