This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Misc updates 0806 #189
Merged
Misc updates 0806 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuvalEvron
suggested changes
Aug 6, 2019
YuvalEvron
approved these changes
Aug 6, 2019
|
Still think the change to |
…MiB'
this improves compatibility with 3rd party tools that dislike the space inside the value, and is more consistent with higher values ('5bytes', '5MiB')
backwards compatibilty is retained in the form of a special formatting specifier: `"{:text}".format(byte) == "1 byte"`
koreno
force-pushed
the
misc-updates-0806
branch
from
fcd81b0
to
68ea679
Compare
I've compensated with a new |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.