This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
PersistentCache: Support optional default #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koreno
suggested changes
Aug 29, 2017
easypy/caching.py
Outdated
| @@ -22,6 +22,7 @@ | |||
| _disable_persistance = bool(os.getenv("bamboo_planKey", os.getenv("WEKA_job_key", None))) # disable this feature when running from bamboo | |||
|
|
|||
|
|
|||
| _NONE = object() | |||
There was a problem hiding this comment.
use an easpy token, that's what they're for.
from easypy.tokens import NO_DEFAULT
unless there's some circular import... but there shouldn't be...
There was a problem hiding this comment.
can't agree with this :/
One thing when you really need to pass token between parts of app - than well, maybe.
Another thing is when it's such case.... Absolutely unnecessary overhead and complexity.
"Use it since we have it" - this is the only reason and it's not good enough
Why would I want to worry, that someone passes this token as default kwarg, due to some logic in app, when this parameter was passed from some function signature, where default was NO_DEFAULT?
tigrawap
force-pushed
the
tigra/persistent-cache-default
branch
3 times, most recently
from
064328b
to
c16f1f8
Compare
tigrawap
force-pushed
the
tigra/persistent-cache-default
branch
from
c16f1f8
to
415df91
Compare
koreno
approved these changes
Aug 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.