This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
concurrency: fix multiexception rendering to include timestamp and context; add timestamp exceptions if concurrent #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntext; add timestamp exceptions if concurrent
koreno
commented
Apr 15, 2018
| for exc in self.actual: | ||
| with buff.indent("{.__class__.__qualname__}", exc): | ||
| if isinstance(exc, self.__class__): |
There was a problem hiding this comment.
(This is actually a bug now that MultiException subtyping is in...)
idanarye
reviewed
Apr 15, 2018
| @@ -343,15 +360,16 @@ def logged_wait(self, timeout=None, initial_log_interval=None): | |||
|
|
|||
|
|
|||
| def _run_with_exception_logging(func, args, kwargs, ctx): | |||
| ctx.update(threadname=threading.current_thread().name) | |||
There was a problem hiding this comment.
ctx['threadname'] = threading.current_thread().name(yea, I know it's unrefactored code, but there is no reason not to use the conventional style here...)
idanarye
approved these changes
Apr 15, 2018
| @@ -936,6 +954,10 @@ def _logged_func(self): | |||
| except Exception as exc: | |||
| _logger.silent_exception("Exception in thread running %s (traceback can be found in debug-level logs)", self.func) | |||
| self.exc = exc | |||
| try: | |||
| exc.timestamp = time.time() | |||
| except Exception: | |||
There was a problem hiding this comment.
What kind of Exception are we expecting here?
There was a problem hiding this comment.
if exc happens to have __slots__ or some __setattribute__ or a read-only timestamp property it might not allow arbitrary attribute assignment.
There was a problem hiding this comment.
And we don't want a more specific exception? Or we just don't want to take the chance an exception logging related code will fail?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of code duplication here, but it's too much to refactor at this stage. In other words, we're looking for bugs, not so much for code elegance...