Skip to content

Commit

Permalink
Outgoing Webhooks setCustomField: Add board name, card name, custom f…
Browse files Browse the repository at this point in the history
…ield name to be visible.

Still missing: custom field value, list name, swimlane name.

Thanks to xet7 !
  • Loading branch information
xet7 committed Jul 10, 2019
1 parent 12795c5 commit 2003d90
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 6 deletions.
4 changes: 3 additions & 1 deletion models/activities.js
Expand Up @@ -189,7 +189,9 @@ if (Meteor.isServer) {
if (activity.customFieldId) {
const customField = activity.customField();
params.customField = customField.name;
params.customFieldValue = customField.text;
params.customFieldValue = Activities.findOne({
customFieldId: customField._id,
}).value;
}
// Label activity did not work yet, unable to edit labels when tried this.
//if (activity.labelId) {
Expand Down
6 changes: 3 additions & 3 deletions models/cards.js
Expand Up @@ -1620,9 +1620,9 @@ if (Meteor.isServer) {
// With a huge database, this result in a very slow app and high CPU on the mongodb side.
// To correct it, add Index to parentId:
Cards._collection._ensureIndex({ parentId: 1 });
/*let notifydays = parseInt(process.env.NOTIFY_DUE_DAYS_BEFORE_AND_AFTER) || 2; // default as 2 days b4 and after
let notifyitvl = parseInt(process.env.NOTIFY_DUE_AT_HOUR_OF_DAY) || 3600 * 24 * 1e3; // default interval as one day
Meteor.call("findDueCards",notifydays,notifyitvl);*/
// let notifydays = parseInt(process.env.NOTIFY_DUE_DAYS_BEFORE_AND_AFTER) || 2; // default as 2 days b4 and after
// let notifyitvl = parseInt(process.env.NOTIFY_DUE_AT_HOUR_OF_DAY) || 3600 * 24 * 1e3; // default interval as one day
// Meteor.call("findDueCards",notifydays,notifyitvl);
Meteor.defer(() => {
addCronJob();
});
Expand Down
8 changes: 6 additions & 2 deletions models/customFields.js
Expand Up @@ -165,11 +165,15 @@ function customFieldDeletion(userId, doc) {
// instead it shows undefined, and no listId and swimlaneId.
function customFieldEdit(userId, doc) {
const card = Cards.findOne(doc.cardId);
const customFieldValue = Activities.findOne({ customFieldId: doc._id }).value;
const boardId = card.boardId;
//boardId: doc.boardIds[0], // We are creating a customField, it has only one boardId
Activities.insert({
userId,
activityType: 'editCustomField',
boardId: doc.boardIds[0], // We are creating a customField, it has only one boardId
activityType: 'setCustomField',
boardId,
customFieldId: doc._id,
customFieldValue,
listId: card.listId,
swimlaneId: card.swimlaneId,
});
Expand Down

0 comments on commit 2003d90

Please sign in to comment.