Skip to content

Commit

Permalink
Fix opening card scrolls to wrong position when many swimlanes and ca…
Browse files Browse the repository at this point in the history
…rd at bottom of board.

Thanks to xet7 !
  • Loading branch information
xet7 committed May 22, 2022
1 parent f1482cf commit adcc33e
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions client/components/cards/cardDetails.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,11 +212,6 @@ BlazeComponent.extendComponent({
//-------------
}

if (!Utils.isMiniScreen()) {
Meteor.setTimeout(() => {
this.scrollParentContainer();
}, 500);
}
const $checklistsDom = this.$('.card-checklist-items');

$checklistsDom.sortable({
Expand Down Expand Up @@ -440,10 +435,20 @@ BlazeComponent.extendComponent({
'click .js-maximize-card-details'() {
Meteor.call('toggleCardMaximized');
autosize($('.card-details'));
if (!Utils.isMiniScreen()) {
Meteor.setTimeout(() => {
this.scrollParentContainer();
}, 500);
}
},
'click .js-minimize-card-details'() {
Meteor.call('toggleCardMaximized');
autosize($('.card-details'));
if (!Utils.isMiniScreen()) {
Meteor.setTimeout(() => {
this.scrollParentContainer();
}, 500);
}
},
'click .js-vote'(e) {
const forIt = $(e.target).hasClass('js-vote-positive');
Expand Down

2 comments on commit adcc33e

@Emile840
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xet7,

Regarding this point, behind the scrolls to wrong position when many swimlanes and cards, there still has a bug, when opening a card, it will be displayed to all swimlanes !

@xet7
Copy link
Member Author

@xet7 xet7 commented on adcc33e Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Emile840

Your issue moved to #4572 (comment)

Please sign in to comment.