Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boards.uniqueTitle not working as expected #4400

Closed
Ben0it-T opened this issue Mar 6, 2022 · 1 comment · Fixed by #4401
Closed

Boards.uniqueTitle not working as expected #4400

Ben0it-T opened this issue Mar 6, 2022 · 1 comment · Fixed by #4401

Comments

@Ben0it-T
Copy link
Contributor

Ben0it-T commented Mar 6, 2022

Issue

Server Setup Information

  • Did you test in newest Wekan?: yes - Wekan 6.09 (snap) / Wekan 6.11 (local)
  • Did you configure root-url correctly so Wekan cards open correctly? yes
  • Operating System: Debian 10
  • Deployment Method: snap

Problem description

At "All boards" (My Boards), when "copy" board ("Duplicate Board"), "copyTitle" returns "uniqueTitle" only if board.title contains "[d+]".

wekan-duplicate-01

wekan-duplicate-02

Reproduction Steps

  1. Create a board, ie. "Test board"
  2. At "All boards" (My Boards), clicks on "Duplicate Board"

Logs

no error in browser console / snap

Discussion

I think this was introduced by #3526

wekan/models/boards.js

Lines 1473 to 1477 in d52e0bc

if (num > 0) {
return `${base} [${num + 1}]`;
}
return title;

If I change/revert to

return `${m.groups.title} [${num + 1}]`;

It seems to work as expected

wekan-duplicate-03

@jrsupplee @xet7
Is it ok for you if I send PR

@xet7
Copy link
Member

xet7 commented Mar 6, 2022

@Ben0it-T

Yes.

@xet7 xet7 closed this as completed in #4401 Mar 6, 2022
xet7 added a commit that referenced this issue Mar 6, 2022
fix Boards.uniqueTitle not working as expected #4400
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants