-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test new WeKan with Meteor 2.7.2 #4512
Comments
|
Hmm, I think I try make new release, so that it will be possible to test this. |
|
@xet7 About convert stylus to CSS: |
|
It is possible that converting to CSS did not convert something, not all Stylus extensions were in use etc. Anyway, it seems to mostly work. |
|
docker-compose.yml seems to work. I have some problems at Sandstorm WeKan sandstorm-io/sandstorm#3618 |
|
With docker-compose.yml from https://github.com/wekan/wekan it's possible to do: That docker-compose.yml has MongoDB 5 etc. |
|
Wow....stranger things here. I didn't nothing and now is working. |
|
I presume it takes some time for all Javascript to load and run. |
|
I had a look at changing the css files are much compressed and many things repeated again before: wekan/client/components/boards/boardColors.styl Lines 81 to 82 in 01a1a2c
after: wekan/client/components/boards/boardColors.css Lines 1 to 72 in f4fe33f
helpful comments are removed before: wekan/client/components/boards/boardColors.styl Lines 357 to 360 in 01a1a2c
after: wekan/client/components/boards/boardColors.css Lines 1023 to 1025 in f4fe33f
it's harder to maintain this css code now before: wekan/client/components/boards/boardColors.styl Lines 1 to 1232 in 01a1a2c
after: wekan/client/components/boards/boardColors.css Lines 1 to 2176 in f4fe33f
Because of the big change it's possible to "get many new style issues". So if i can make a suggestion i think it's better to make the necessary migrations to the latest stylus version instead of "changing the whole weel". |
|
Changing this wheel fixed a lot of bugs. I will fix UI issues. |
|
I see. I think i was missing that issues. |
|
Changing to Stylus also fixed this kind of errors when building WeKan Meteor-Community-Packages/meteor-stylus#9 |
|
Mainly:
|
|
I did previously increase stack size for WeKan, trying if those help with exceeded error messages. But that could also increase RAM requirements. With Meteor 2.2 version, something in WeKan code caused memory leaks, so RAM and CPU usage was growing both at browserside and serverside. I'm trying to remove extra code, and with that make WeKan run faster, and use less RAM and CPU. |
|
Currently there are many themes, where only difference is 1 or 2 colors. That causes duplication of CSS. Sometime those will be combined, and added settings to change to any color. |
|
ill try to look through all the css and touch up on the left out stuff if i find anything critical the next days |
|
Thank you for the links and explaining. |
|
With newest WeKan, I don't know why changing Swimlane color reloads page. Wekan partially works like SPA (Single Page Application, automatically updating in place), partially like MPA (Multi Page Application application, always loading whole page), and also too much is loaded to browserside at once. I'm trying to make changes so that for non-JS browsers, WeKan would work like MPA with HTML/CSS only and be visible and accessible (currently WeKan displays nothing on non-JS browsers), and where browser supports Javascript it would run that additional SPA features code like current Meteor WeKan realtime UI. |
|
Problem with minimongo and optimistic UI is that there is not yet indicator when change is saved to database #3071 (comment) For example, to customer happened, that he made a lot of changes for 30 minutes, closed webbrowser, and those changes were lost. So sometime I'll try add that indicator, and remove minimongo, optimistic UI etc from browserside. With that much less code, it will make webpages to load faster. Some related code is at https://github.com/wekan/we . Anyway, plan is to only change required parts of current WeKan code to make that happen. WeKan has a lot of code that already works well. |
|
Maybe this save issue doesn't exists with Meteor 2.7.2 anymore. |
|
Meteor 2.7.2 is much faster than Meteor 2.2, I don't know does that issue happen anymore. Currently this is extra change I added, it only makes that ul li same color as background, but anyway that is extra border taking too much space. Similar li elements are also at Admin Panel, but I have not changed them. |
|
@xet7 So there is extra margin / padding at the top of the list and the first minicard. before: after: |
|
Maybe it's related to this: Did you remove the |
|
Yes, because newest stylus npm package does not support that |
xet7
added a commit
that referenced
this issue
May 18, 2022
…let points. Thanks to mfilser and xet7 ! Related #4512 (comment)
|
Thanks! I fixed those extra li bullets etc UI issues by adding that code at #4512 (comment) to |
|
@xet7 |
|
I added wiki page for more clear summary: https://github.com/wekan/wekan/wiki/Converting-Meteor-Stylus-to-CSS |
|
Using v6.26, I cannot change language on my other PCs it's just untranslated as seen on the screenshot. I use Docker or source using Ubuntu 22.04
|
|
@xet7 already seen, and done as described on both PCs. On host PC, works as intended. On alt PCs, it doesn't. Tried using chrome and edge, same results. |
|
What language are you trying to use? |
|
Did you set ROOT_URL correctly? https://github.com/wekan/wekan/wiki/Settings For example, see ip address with command on WSL2: And then in start-wekan.sh, set your WSL2 ip address here: And then at remote PC, browse to http://192.168.0.200 |
|
Also, WSL2 has some problems with network access, because of resolv.conf . To fix it, edit it: And there change it to some working nameserver, like cloudflare: Or Google: Then Ctrl-o Enter Ctrl-x. |
|
Also at that resolv.conf is info how to keep network settings: |
English, tried other languages too with no result.
Already done, with ports on firewall too.
Did that too, no result. It was working just fine at wekan v6.22 though, no changes on my configuration. But after updating to v6.23-v.6.26 it doesn't change to any language. It's like it's not reading the i18n files. |
|
Maybe it's some other problem with WSL2 ? Can you try Docker version docker-compose.yml from https://github.com/wekan/wekan ? It's Linux container type. |
Docker-compose did the work. Thanks a lot for your kind help. |
|
@xet7 Isn't this done? https://github.com/wekan/wekan/releases/tag/v6.56 Seems that latest release already uses 2.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
6 participants
@mfilser @helioguardabaxo @imajus @TheExo
Newest Meteor 2.7.2
Stylus to CSS
About login
The text was updated successfully, but these errors were encountered: