Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codeblocks should not be scanned for emoji #643

Closed
Ryman opened this issue Jul 16, 2016 · 2 comments
Closed

Codeblocks should not be scanned for emoji #643

Ryman opened this issue Jul 16, 2016 · 2 comments
Labels
Bug Feature:Editor

Comments

@Ryman
Copy link

Ryman commented Jul 16, 2016

It breaks the ability to copy code later from a comment, e.g. with rust code:

use std::mem::transmute;

// becomes
use std: [:mem:] :transmute;
@mquandalle
Copy link
Contributor

Yes, see also #323.

@DrCuriosity
Copy link

I've just experienced this problem with putting timestamps on a card. A "16:08:03" tries to extract the middle ":08:" as an emoji, even when escaped.

@xet7 xet7 mentioned this issue Sep 25, 2017
Closed
@xet7 xet7 closed this as completed in c4fd729 Sep 25, 2017
xet7 added a commit that referenced this issue Sep 25, 2017
@xet7
Add emojis back, because removing them broke local dev Sandstorm.
a62c8eb 
Thanks to xet7 ! Opens #1248, opens #743, opens #643, opens #323
@xet7 xet7 reopened this Sep 25, 2017
@xet7 xet7 closed this as completed in 8ae9cb9 Nov 18, 2017
xet7 added a commit that referenced this issue Nov 18, 2017
@xet7
Merge branch 'brooksbecton-addMarkdownToTitle' into devel
13d8e75 
Markdown in card/minicard/checlist titles
and checklist items. Next line: Shift+Enter. Submit: Enter. Closes #926.
Fix: Emoji detection breaks MAC addresses. Closes #1248.
Fix: Codeblocks should not be scanned for emoji. Closes #643.
Fix: Whitespace trimming breaks Markdown code block indentation. Closes #1288.
Thanks to brooksbecton !
thuanpq added a commit to thuanpq/wekan that referenced this issue Nov 19, 2017
@thuanpq
Merge commit 'eceaac799884ded6586940b0716a3020fa36022d' into card-del…
76d75e1 
…eting-setting

* commit 'eceaac799884ded6586940b0716a3020fa36022d':
  Fix: Helper to list boards for user. Thanks to milesibastos ! Closes wekan#1326
  Update translations.
  User Admin to Admin Panel: List users. Change: is user admin, name, fullname, email address, is user active. Not changing password yet. Thanks to thuanpq and xet7 ! Related wekan#802
  Change admin panel header order to info people version.
  Make Admin Panel People page text translateable
  Markdown in card/minicard/checlist titles and checklist items. Next line: Shift+Enter. Submit: Enter. Closes wekan#926. Fix: Emoji detection breaks MAC addresses. Closes wekan#1248. Fix: Codeblocks should not be scanned for emoji. Closes wekan#643. Fix: Whitespace trimming breaks Markdown code block indentation. Closes wekan#1288. Thanks to brooksbecton !
  Fix Missing trailing comma in users.js
  Updated comments about pressing enter on forms
  Added markdown support to card-titles, minicard-titles, checklist title, and checklist items
  Added update all user profile from admin panel
  Updated users methods to get user id from client on updating user data, is aimed to support admin update other user profile
  Added pagination to people management in admin panel
  Added edit user from admin panel
  Added people list in admin panel , just raw data right now, will add more features soon
  Add .idea to .gitignore
  Add REST API better error output

# Conflicts:
#	i18n/ar.i18n.json
#	i18n/br.i18n.json
#	i18n/ca.i18n.json
#	i18n/cs.i18n.json
#	i18n/de.i18n.json
#	i18n/en-GB.i18n.json
#	i18n/eo.i18n.json
#	i18n/es-AR.i18n.json
#	i18n/es.i18n.json
#	i18n/eu.i18n.json
#	i18n/fa.i18n.json
#	i18n/fi.i18n.json
#	i18n/fr.i18n.json
#	i18n/gl.i18n.json
#	i18n/he.i18n.json
#	i18n/hu.i18n.json
#	i18n/id.i18n.json
#	i18n/it.i18n.json
#	i18n/ja.i18n.json
#	i18n/ko.i18n.json
#	i18n/nb.i18n.json
#	i18n/nl.i18n.json
#	i18n/pl.i18n.json
#	i18n/pt-BR.i18n.json
#	i18n/ro.i18n.json
#	i18n/ru.i18n.json
#	i18n/sr.i18n.json
#	i18n/sv.i18n.json
#	i18n/ta.i18n.json
#	i18n/th.i18n.json
#	i18n/tr.i18n.json
#	i18n/uk.i18n.json
#	i18n/vi.i18n.json
#	i18n/zh-CN.i18n.json
#	i18n/zh-TW.i18n.json
thuanpq added a commit to thuanpq/wekan that referenced this issue Nov 19, 2017
@thuanpq
Merge commit 'eceaac799884ded6586940b0716a3020fa36022d' into log-spen…
34b113e 
…t-time

* commit 'eceaac799884ded6586940b0716a3020fa36022d':
  Fix: Helper to list boards for user. Thanks to milesibastos ! Closes wekan#1326
  Update translations.
  User Admin to Admin Panel: List users. Change: is user admin, name, fullname, email address, is user active. Not changing password yet. Thanks to thuanpq and xet7 ! Related wekan#802
  Change admin panel header order to info people version.
  Make Admin Panel People page text translateable
  Markdown in card/minicard/checlist titles and checklist items. Next line: Shift+Enter. Submit: Enter. Closes wekan#926. Fix: Emoji detection breaks MAC addresses. Closes wekan#1248. Fix: Codeblocks should not be scanned for emoji. Closes wekan#643. Fix: Whitespace trimming breaks Markdown code block indentation. Closes wekan#1288. Thanks to brooksbecton !
  Fix Missing trailing comma in users.js
  Updated comments about pressing enter on forms
  Added markdown support to card-titles, minicard-titles, checklist title, and checklist items
  Added update all user profile from admin panel
  Updated users methods to get user id from client on updating user data, is aimed to support admin update other user profile
  Added pagination to people management in admin panel
  Added edit user from admin panel
  Added people list in admin panel , just raw data right now, will add more features soon
  Add .idea to .gitignore
  Add REST API better error output

# Conflicts:
#	i18n/en.i18n.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Feature:Editor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xet7 @Ryman @mquandalle @DrCuriosity