New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integrations #1199

Merged
merged 3 commits into from Sep 1, 2017

Conversation

Projects
None yet
2 participants
@andresmanelli
Copy link
Contributor

andresmanelli commented Aug 30, 2017

The idea

Right now, you could only add one webhook from the UI. I added the ability to save many integrations per board (and show them in the UI).

Also, sometimes you may want to subscribe to only certain activities, such as act-moveCard. For this purpose I added a field named activities to the schema of Integrations. Default value is all which gives backwards compatibility.

Before executing outgoingWebhooks, integrations are filtered based on the activities field.

userId autoValue()

  • In order to be able to CRUD integrations from the added API, I had to delete the autoValue() for userId, as this.userId was null. Then you provide explicitly the userId from the request body. Is there other way to do this?

Snapshots

New integration form

seleccion_001

Existing integrations

seleccion_003

(Unknown) refers to the titlefield, which for the moment only can be set from the API


This change is Reviewable

@xet7 xet7 merged commit 1048718 into wekan:devel Sep 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment