Improve integrations #1199
Merged
Improve integrations #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea
Right now, you could only add one webhook from the UI. I added the ability to save many integrations per board (and show them in the UI).
Also, sometimes you may want to subscribe to only certain activities, such as
act-moveCard. For this purpose I added a field namedactivitiesto the schema of Integrations. Default value isallwhich gives backwards compatibility.Before executing
outgoingWebhooks, integrations are filtered based on theactivitiesfield.userId autoValue()
this.userIdwasnull. Then you provide explicitly the userId from the request body. Is there other way to do this?Snapshots
New integration form
Existing integrations
(Unknown)refers to thetitlefield, which for the moment only can be set from the APIThis change is