Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List header contains now a button to add the card to the bottom of the list #4195

Merged
merged 8 commits into from
Nov 29, 2021

Conversation

mfilser
Copy link
Contributor

@mfilser mfilser commented Nov 25, 2021

adding a button to add cards at the bottom of the list.
Here is a screenshot (see green marker)
grafik

I haven't found a better icon on https://fontawesome.com/icons


This change is Reviewable

@xet7
Copy link
Member

xet7 commented Nov 25, 2021

@mfilser

AFAIK WeKan uses https://fontawesome.com/v4.7/icons/

@xet7
Copy link
Member

xet7 commented Nov 25, 2021

@mfilser

You could try combination of + and some up or down icons, if you would like to have something like that.

@mfilser
Copy link
Contributor Author

mfilser commented Nov 25, 2021

Good idea to use a combination of 2 icons. I am not sure if the "user" see the 2 icon as one icon or expect to have 2 "features".

@xet7
Copy link
Member

xet7 commented Nov 25, 2021

User does see it as one icon, if you add some shadow or border to below of those 2 combined icons.

@mfilser
Copy link
Contributor Author

mfilser commented Nov 25, 2021

I will try it, thank you 🙂

- there isn't a good plus icon which means the card is added at the
  bottom, so i try to use 2 icons for this feature
@mfilser
Copy link
Contributor Author

mfilser commented Nov 27, 2021

@xet7
I added a arrow down icon, it looks now: (only green highlighted for the screenshot)
grafik

If you like, it's "merge able" 🙂

@helioguardabaxo
Copy link
Contributor

@mfilser
If "create card on top" has an arrow (top arrow), the list header will be polluted?

@mfilser
Copy link
Contributor Author

mfilser commented Nov 27, 2021

@helioguardabaxo
I don't understand it correctly. Can you maybe send a screenshot or something else which explains it in another way?

@helioguardabaxo
Copy link
Contributor

@mfilser
Something like this:
143678495-ac591b1e-830f-4878-945b-02526b94fb17

@mfilser
Copy link
Contributor Author

mfilser commented Nov 27, 2021

I see, thank you a lot for your screenshot. That's a good idea, i will check it and try if there is enough space at mobile view too

@mfilser
Copy link
Contributor Author

mfilser commented Nov 27, 2021

grafik

@mfilser
Copy link
Contributor Author

mfilser commented Nov 27, 2021

"Merge able" again if it's "good enough" 🙂

@xet7
Copy link
Member

xet7 commented Nov 28, 2021

Unfortunately, those buttons take away some of that precious space of list name. Also when list title is long, both those new buttons of creating new card to top/bottom and current one button of creating new card to top are top or below of list title, making hard to see both list title text and that button.

Well, maybe:

a) It should be fixed that buttons are not below or top of list title

b) That Add card top top and Add card to bottom should be at list hamburger menu at top of menu

But I don't know yet what would make most sense, I should think sometime. Or, if someone creates PR that makes more sense.

@mfilser
Copy link
Contributor Author

mfilser commented Nov 28, 2021

Well, that's right, i didn't think of long list names.
I think i move "add card to bottom" to the hamburger menu and send the new commits here.

@mfilser
Copy link
Contributor Author

mfilser commented Nov 28, 2021

@xet7
Moved to hamburger menu

@xet7
Copy link
Member

xet7 commented Nov 29, 2021

@mfilser

I mean, in this screenshot, list title text word Three and button + overlap:

plus

@mfilser
Copy link
Contributor Author

mfilser commented Nov 29, 2021

Thank you for the screenshot.
This overlap is here since month/years, it wasn't introduced by this PR. This PR only changes the Hamburger Menu.

@xet7
Copy link
Member

xet7 commented Nov 29, 2021

@mfilser

Oh OK ! Thanks! I will merge this later so this will be in WeKan v5.82 . Currently I'm releasing WeKan v5.81 .

@mfilser
Copy link
Contributor Author

mfilser commented Nov 29, 2021

@xet7
Great, thank you.
I add it to my "todo" list and send a seperate PR if i find a solution.

@xet7 xet7 merged commit b8a976d into wekan:master Nov 29, 2021
mfilser added a commit to mfilser/wekan that referenced this pull request Nov 30, 2021
- fix overflow bug if list name is too long
wekan#4195 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants